[Rule Registry] Rewrite APM registry rules for Observability #117740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
v8.0.0
Feature:Observability RAC
v8.1.0
Team: Actionable Observability - DEPRECATED
…write-apm-rule-registry-test
…write-apm-rule-registry-test
…write-apm-rule-registry-test
|
@simianhacker fwiw, this was already an API test? |
simianhacker
added
release_note:fix
release_note:skip
|
@dgieselaar Not sure what you mean? It was an API test under APM. From the description in the linked issue, @weltenwort wanted it moved to Observability. |
|
@simianhacker this issue description says:
But APM's Registry Rules tests were already part of the Kibana API tests. They were not written with Cypress. |
|
@dgieselaar Sorry... I misunderstood, I thought the tests under |
dgieselaar
approved these changes
Nov 10, 2021
simianhacker
changed the title
|
@dgieselaar I'm not sure if you want to "re-review" this. I moved all the tests under |
dgieselaar
approved these changes
Nov 11, 2021
…write-apm-rule-registry-test
claudiopro
reviewed
Nov 16, 2021
x-pack/test/rule_registry/common/lib/helpers/cleanup_target_indices.ts
Outdated
Show resolved
Hide resolved
…write-apm-rule-registry-test
…write-apm-rule-registry-test
claudiopro
reviewed
Nov 29, 2021
| @@ -22,8 +22,9 @@ export default ({ loadTestFile, getService }: FtrProviderContext): void => { | |||
| await deleteSpaces(getService); | |||
| }); | |||
|
|
|||
| // Basic | |||
| // Trial | |||
There was a problem hiding this comment.
Was Basic the old marketing name? Nevermind, it seems you're fixing some copypasta.
claudiopro
approved these changes
Nov 29, 2021
|
FYI the link to APM's Registry Rules test in the description is broken. |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
simianhacker
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 6, 2021
…#117740) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2021
#120557) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Chris Cowan <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 7, 2021
…-chromium-before-compiling-pdf * 'main' of github.com:elastic/kibana: (121 commits) FTR should use the new kibana_system user (elastic#120436) [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list (elastic#120488) [Reporting] Fix slow CSV with large max size bytes (elastic#120365) [CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations - (elastic#120459) [Dashboard] Added KibanaThemeProvider. (elastic#120122) add more rule_registry unit tests (elastic#120323) [Lens] update xpack.lens.pie.smallValuesWarningMessage text (elastic#120478) [Fleet] Simplified package policy create API, enriching default values (elastic#119739) mock `elastic-apm-node` in `@kbn/test` jest preset (elastic#120324) [RAC] Rename occurrences of alert_type to rule_type in Infra (elastic#120455) [Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (elastic#120437) [Workplace Search] Add API Keys view to replace Access tokens (elastic#120147) [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the server section (elastic#120411) Add support for threat.feed.name (elastic#120250) [Rule Registry] Rewrite APM registry rules for Observability (elastic#117740) [docs] Fix artifact layout formatting (elastic#119386) [Workplace Search] Add a technical preview of connecting GitHub via GitHub apps (elastic#119764) add osquery notes for 7.16 (elastic#120407) chore(NA): splits types from code on @kbn/docs-utils (elastic#120533) [Reporting] Decouple screenshotting plugin from the reporting (elastic#120110) ... # Conflicts: # x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.test.ts # x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.ts # x-pack/plugins/reporting/server/test_helpers/create_mock_browserdriverfactory.ts
Heenawter
pushed a commit
to Heenawter/kibana
that referenced
this pull request
Dec 8, 2021
…#117740) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…#117740) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]>
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
…#117740) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #110637 by rewriting APM's Registry Rules test and moving it to the Rule Registry tests.
Checklist